This repository was archived by the owner on Sep 9, 2025. It is now read-only.
Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the issue with nested assignments in Python by creating an output node for assignment expressions. The changes ensure that nested assignments like "y = z = 1337" are handled correctly, and they add tests to verify the fix.
Files not reviewed (1)
- languages/tree-sitter-stack-graphs-python/src/stack-graphs.tsg: Language not supported
Contributor
|
The github/stack-graphs repository is no longer being maintained. As per #502, I'm closing all issues and pull requests before archiving the repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python supports “nested” assignments like
x = y = 42. In that particular context the nestedy = 42assignment sort of acts like an expression, and the result is bound to the LHS of the first assignment:x = <result>. However, assignments are not generally considered expressions, and as such the TSSG definition does not create anoutputnode for it, causing an error in the the stanza that deals with assignments:The fragment of the parsed Tree-sitter tree for such a nested assignment is:
As of v0.23.5 of the Python grammar, the
rightfield of anassignmentindeed accepts anotherassignment(via_right_hand_side).Simply creating an
outputnode for anassignmentfixes the issue. Copious testing reveals no negative side effects.